View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000458 | Cinelerra-GG | Bug | public | 2020-06-26 16:41 | 2021-06-15 22:32 |
| Reporter | mehw | Assigned To | PhyllisSmith | ||
| Priority | immediate | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Linux x86_64 | OS | Gentoo | OS Version | rolling |
| Summary | 0000458: compilation error: class Track has no member named record | ||||
| Description | As per commit 48a6854a1ca58aa291ffc6fe3a48807492dfbef7, the member 'record' of the class 'Track' is replaced with the method 'is_armed'. Two lines in 'cinelerra-5.1/cinelerra/commercials.C' still require to be fixed. The fix is trivial and a patch is attached. Cheers! | ||||
| Steps To Reproduce | When 'cinelerra-5.1/cinelerra/commercials.C' is copmiled (which may depend on the configuration used) the build process exits with errors. | ||||
| Additional Information | commercials.C: In member function ‘int Commercials::scan_audio(int, double, double)’: commercials.C:554:14: error: ‘class Track’ has no member named ‘record’ 554 | if( !atrk->record ) continue; | ^~~~~~ commercials.C: In member function ‘int Commercials::scan_video()’: commercials.C:595:14: error: ‘class Track’ has no member named ‘record’ 595 | if( !vtrk->record ) continue; | ^~~~~~ At global scope: cc1plus: warning: unrecognized command line option ‘-Wno-unknown-warning-option’ make[2]: *** [Makefile:563: x86_64/commercials.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/var/tmp/portage/media-video/cinelerra-gg-9999/work/cinelerra-gg-9999/cinelerra-5.1/cinelerra' make[1]: *** [Makefile:527: all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/media-video/cinelerra-gg-9999/work/cinelerra-gg-9999/cinelerra-5.1' make: *** [Makefile:483: all] Error 2 | ||||
| Tags | bug | ||||
| Attached Files | cinelerra-gg-fix-track-operations.patch (1,119 bytes)
As per commit 48a6854a1ca58aa291ffc6fe3a48807492dfbef7, fix armed track operations.
diff -Nuar a/cinelerra-5.1/cinelerra/commercials.C b/cinelerra-5.1/cinelerra/commercials.C
--- a/cinelerra-5.1/cinelerra/commercials.C 2020-06-26 13:38:35.393203559 +0000
+++ b/cinelerra-5.1/cinelerra/commercials.C 2020-06-26 13:49:34.314169992 +0000
@@ -551,7 +551,7 @@
Tracks *tracks = mwindow->edl->tracks;
for(Track *atrk=tracks->first; !cancelled && atrk; atrk=atrk->next) {
if( atrk->data_type != TRACK_AUDIO ) continue;
- if( !atrk->record ) continue;
+ if( !atrk->is_armed() ) continue;
Edits *edits = atrk->edits; Edit *next = 0;
for( Edit *edit=edits->first; !cancelled && edit; edit=next ) {
next = edit->next;
@@ -592,7 +592,7 @@
Tracks *tracks = mwindow->edl->tracks;
for( Track *vtrk=tracks->first; !cancelled && vtrk; vtrk=vtrk->next) {
if( vtrk->data_type != TRACK_VIDEO ) continue;
- if( !vtrk->record ) continue;
+ if( !vtrk->is_armed() ) continue;
Edits *edits = vtrk->edits; Edit *next = 0;
for( Edit *edit=edits->first; !cancelled && edit; edit=next ) {
next = edit->next;
| ||||
|
|
@mehw Thanks for reporting. We will look into this today. |
|
|
The patch was applied/tested here and it worked perfectly. It is now checked into GIT. We appreciate your help as we would not have discovered this error for a long time since in order to speed up compiles we usually leave this feature off. |
|
|
@PhyllisSmith Thank you for your prompt action. It's greatly appreciated. Godspeed! |
|
|
Forgot to close this. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-06-26 16:41 | mehw | New Issue | |
| 2020-06-26 16:41 | mehw | Tag Attached: bug | |
| 2020-06-26 16:41 | mehw | File Added: cinelerra-gg-fix-track-operations.patch | |
| 2020-06-26 17:17 | PhyllisSmith | Note Added: 0003659 | |
| 2020-06-27 02:45 | PhyllisSmith | Assigned To | => PhyllisSmith |
| 2020-06-27 02:45 | PhyllisSmith | Status | new => confirmed |
| 2020-06-27 02:45 | PhyllisSmith | Note Added: 0003661 | |
| 2020-06-27 19:27 | mehw | Note Added: 0003665 | |
| 2021-06-15 22:32 | PhyllisSmith | Status | confirmed => closed |
| 2021-06-15 22:32 | PhyllisSmith | Resolution | open => fixed |
| 2021-06-15 22:32 | PhyllisSmith | Note Added: 0004823 |
