View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000532Cinelerra-GGBugpublic2020-10-29 13:162020-11-01 20:01
Reportermehw Assigned ToPhyllisSmith  
PriorityimmediateSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
PlatformLinux x86_64OSGentooOS Versionrolling
Fixed in Version2020-10 
Summary0000532: compilation error: cannot convert ‘VIFrame’ to ‘VFrame*’
DescriptionPart of the error log is posted as Additional Information. A patch is attached to this post.

The first problem about "cannot convert ‘VIFrame’ to ‘VFrame*’" is at dbwindow.C:392, the second problem is at dbwindow.C:421.

Both the problems relate to the use of the class VIFrame (vicon.h). To return a VFrame pointer (VFrame *) via the VIFrame class, it's sufficient to return the VIFrame member vfrm.
Steps To ReproduceWhen 'cinelerra-5.1/cinelerra/dbwindow.C' is copmiled (which may depend on the configuration used) the build process exits with errors.
Additional Informationc++ `cat x86_64/c_flags` -DMSGQUAL=dbwindow -c dbwindow.C -o x86_64/dbwindow.o
dbwindow.C: In member function ‘virtual VFrame* DbWindowVIcon::frame()’:
dbwindow.C:392:9: error: cannot convert ‘VIFrame’ to ‘VFrame*’ in return
392 | return *images[seq_no];
dbwindow.C: In member function ‘void DbWindowVIcon::read_frames(DbWindow::MDb*)’:
dbwindow.C:421:17: error: cannot convert ‘VIFrame’ to ‘VFrame*’ in initialization
421 | VFrame *img = *vifrm;
| ^~~~~~
| |
| VIFrame
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-unknown-warning-option’
make[2]: *** [Makefile:563: x86_64/dbwindow.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/var/tmp/portage/media-video/cinelerra-gg-9999/work/cinelerra-gg-9999/cinelerra-5.1/cinelerra'
make[1]: *** [Makefile:528: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-video/cinelerra-gg-9999/work/cinelerra-gg-9999/cinelerra-5.1'
make: *** [Makefile:484: all] Error 2
Tagsbug
Attached Files
cinelerra-gg-9999-fix-VFrame-return.patch (767 bytes)    
diff -Nuar a/cinelerra/dbwindow.C b/cinelerra/dbwindow.C
--- a/cinelerra/dbwindow.C	2020-10-29 04:13:31.465920793 +0100
+++ b/cinelerra/dbwindow.C	2020-10-29 04:10:25.295647739 +0100
@@ -389,7 +389,7 @@
 {
 	if( seq_no >= images.size() )
 		load_frames(lbox->gui->dwindow->mdb);
-	return *images[seq_no];
+	return images[seq_no]->vfrm;
 }
 
 int64_t DbWindowVIcon::set_seq_no(int64_t no)
@@ -418,7 +418,7 @@
 		if( frame_id < 0 ) continue;
 		int swidth = (SWIDTH+1) & ~1, sheight = (SHEIGHT+1) & ~1;
 		VIFrame *vifrm = new VIFrame(swidth, sheight, BC_YUV420P);
-		VFrame *img = *vifrm;
+		VFrame *img = vifrm->vfrm;
 		memset(img->get_y(),0x00,swidth * sheight);
 		memset(img->get_u(),0x80,swidth/2 * sheight/2);
 		memset(img->get_v(),0x80,swidth/2 * sheight/2);
cinelerra-gg-9999-fix-VFrame-return.patch (767 bytes)   

Activities

PhyllisSmith

2020-10-29 17:54

manager   ~0004320

@mehw
Thank you so much for the report and patch. It has been successfully test compiled here and the patch checked into GIT

mehw

2020-10-29 23:22

reporter   ~0004321

@PhyllisSmith
Thank you for your prompt response.

Cheers.

PhyllisSmith

2020-10-29 23:34

manager   ~0004322

Will close after new builds.

PhyllisSmith

2020-11-01 20:01

manager   ~0004334

Great find and patch! Done.

Issue History

Date Modified Username Field Change
2020-10-29 13:16 mehw New Issue
2020-10-29 13:16 mehw Tag Attached: bug
2020-10-29 13:16 mehw File Added: cinelerra-gg-9999-fix-VFrame-return.patch
2020-10-29 17:54 PhyllisSmith Assigned To => PhyllisSmith
2020-10-29 17:54 PhyllisSmith Status new => confirmed
2020-10-29 17:54 PhyllisSmith Note Added: 0004320
2020-10-29 23:22 mehw Note Added: 0004321
2020-10-29 23:34 PhyllisSmith Status confirmed => resolved
2020-10-29 23:34 PhyllisSmith Resolution open => fixed
2020-10-29 23:34 PhyllisSmith Fixed in Version => 2020-10
2020-10-29 23:34 PhyllisSmith Note Added: 0004322
2020-11-01 20:01 PhyllisSmith Status resolved => closed
2020-11-01 20:01 PhyllisSmith Note Added: 0004334