View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000584Cinelerra-GGBugpublic2021-08-05 07:332021-08-09 20:07
Reportermehw Assigned ToPhyllisSmith  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Platformamd64OSGentooOS Versionrolling
Summary0000584: failure `cd x265*` during compilation due to multiple x265* files/directories under the same path
DescriptionAs of commit 64611a5395232c3a1817dbb1c98bb9d3bd62b796, the file 'x265_compile_multibit.patch' and the directory 'x265_3.5' (or 'x265_3.4') are both under the same path 'cinelerra-5.1/thirdparty/' during compilation.

It's impossible to `cd x265*`... Please, move the file 'x265_compile_multibit.patch' elsewhere, maybe under 'cinelerra-5.1/thirdparty/src/'.

Also, I do not understand how the patch 'x265_compile_multibit.patch' is applied. Should it be applied automatically or manually?
Steps To ReproduceCompile with x265 support, either thirdparty or system libraries.
Additional Informationcd x265* && echo 'cmake "$@" "source"' > ./configure; chmod +x ./configure; ./configure -DHIGH_BIT_DEPTH:BOOL=ON -DENABLE_SHARED=no
/bin/bash: line 1: cd: too many arguments
chmod: cannot access './configure': No such file or directory
/bin/bash: line 1: ./configure: No such file or directory
make[2]: *** [Makefile:357: /var/tmp/portage/media-video/cinelerra-gg-9999/work/cinelerra-gg-9999/cinelerra-5.1/thirdparty/../thirdparty/build/x265.configure] Error 127
Tagsbug
Attached Files
0001-move-x265_compile_multibit.patch-in-different-path.patch (974 bytes)    
From 5864f70d5feaa249e32ea6947ad64bcff6dfeed6 Mon Sep 17 00:00:00 2001
From: Matthew White <mehw.is.me@inventati.org>
Date: Thu, 5 Aug 2021 05:26:42 +0000
Subject: [PATCH] move x265_compile_multibit.patch in different path

During compilation, `cd x265*` will fail trying either to change
directory to the file x265_compile_multibit.patch, as if it is a
directory, or because there are multiple x265* files/directories
under the same path, i.e. the former file and the x265_3.5 dir.
---
 cinelerra-5.1/thirdparty/{ => src}/x265_compile_multibit.patch | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename cinelerra-5.1/thirdparty/{ => src}/x265_compile_multibit.patch (100%)

diff --git a/cinelerra-5.1/thirdparty/x265_compile_multibit.patch b/cinelerra-5.1/thirdparty/src/x265_compile_multibit.patch
similarity index 100%
rename from cinelerra-5.1/thirdparty/x265_compile_multibit.patch
rename to cinelerra-5.1/thirdparty/src/x265_compile_multibit.patch
-- 
2.31.1
0001-move-x265_compile_multibit.patch-in-different-path.patch (974 bytes)   

Activities

PhyllisSmith

2021-08-05 15:58

manager   ~0004901

@mehw
This was indeed a very bad name. I will fix it today. Sorry for creating a problem -- I am not very good at this.
About: "how the patch 'x265_compile_multibit.patch' is applied. Should it be applied automatically or manually?"
It is not to be applied at all unless you want the capability to handle 10 and 12 bit video rendering. The manual was updated yesterday to explain its usage and will be fixed after I fix the code.

1.8 Multibit build for 8/10/12-bit Handling
***********************************
To build a version that can handle 8 bit, or 10 bit, or 12 bit videos, a patch is provided in the thirdparty subdirectory that needs to be applied to do so. Be aware that the compile will take a substantial amount of extra time. To apply the required
patch:

cd location of your cinelerra/cinelerra-5.1/thirdparty
patch < x265_compile_multibit.patch
mv x265_3.5.patch* src/.

Render formats h265-10bit and h265-12bit have been provided and will be operational after the applied patch is compiled in.

PhyllisSmith

2021-08-06 01:11

manager   ~0004902

Last edited: 2021-08-06 01:12

 @mehw
Thanks for letting us know about the naming problem. I do not know what I did not encounter this problem because I suppose it is because I use different procedures. Anyway the file has been rename compile_multibit_X265.txt so none of the automatic procedures will pick it up ! decided to be overly cautious and change lower case x to upper case x, not start the filename with x265, AND even replaced the patch extension with txt ! Checked changes into GIT (and for the manual).

More testing over time is probably needed for 10 and 12 bit usage and the non-standard x265 library so I would not put this patch into normal user builds yet.

I will close this BT in a couple of days.

Issue History

Date Modified Username Field Change
2021-08-05 07:33 mehw New Issue
2021-08-05 07:33 mehw Tag Attached: bug
2021-08-05 07:33 mehw File Added: 0001-move-x265_compile_multibit.patch-in-different-path.patch
2021-08-05 15:58 PhyllisSmith Note Added: 0004901
2021-08-05 15:59 PhyllisSmith Assigned To => PhyllisSmith
2021-08-05 15:59 PhyllisSmith Status new => acknowledged
2021-08-06 01:11 PhyllisSmith Note Added: 0004902
2021-08-06 01:12 PhyllisSmith Note Edited: 0004902
2021-08-09 20:07 PhyllisSmith Status acknowledged => closed
2021-08-09 20:07 PhyllisSmith Resolution open => fixed