View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000608 | Cinelerra-GG | Bug | public | 2022-03-22 17:52 | 2022-04-01 18:57 |
| Reporter | sge | Assigned To | PhyllisSmith | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0000608: Quirks requesting context help for Shuttle | ||||
| Description | When using Contour Shuttle, there came out some quirks. Sometimes pressing a shuttle button did nothing, sometimes there came the manual page for Shuttle although I did not request help. The source of this bug is the following. The Cinelerra keystroke event handling was designed in such a way that not the really current state of modifiers (Shift, Ctrl, Alt) was memorized, but the state which was active just before the keystroke (or key release). So, when the user pressed, let's say, Alt-Right (go to next asset), after releasing both keys the state 'Alt pressed' remained in memory. If then a shuttle button would be pressed, it would come under such spurious 'Alt pressed' state causing help page for Shuttle instead of the actual command assigned to the button. The patch here corrects the problem. Now the actual state of modifiers (pressed or released) is always maintained. The Shuttle functions as it should. Moreover, the ugly 'double Alt' together with shuttle button is not necessary to request the manual page for Shuttle; the simple Alt-shuttlebutton (with single Alt) is sufficient. The same quirk with wrong state of modifiers could, potentially, influence some other places of the program, but I found none. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
|
|
Testing patch now - with both types of shuttles. |
|
|
After patching, testing and checking in this chunk of code, the following changes in the CGG manual should be done. 1) In Section 5.10.3 Shuttle key default arrangement for CINELERRA-GG / Composer / Viewer: The following is the default setting for the ShuttlePROv2 and ShuttleXpress (table 5.3 and table 5.4). This page can be quickly requested from CINELERRA-GG by simultaneous pressing the Alt key on the keyboard and any button on the Shuttle. How to "cancel this mode" is obsolete and should be removed from the manual. Alt-shuttlebutton is modeless now and needs not to be "cancelled". 2) In Section 18.1.3 Requesting context help on Contour Shuttle: Contour Shuttle has no Alt/h. Nevertheless, its help page can be requested by simultaneously pressing the Alt key on the keyboard and any button on the Contour Shuttle. Note that the default Shuttle Configuration will be shown, rather than the one that you may have redefined. The description of X11 tracking status of modifiers and cancellation of "shuttle help mode" is obsolete and should to be deleted from this Section. |
|
|
Works great! both the code and the manual changes have been checked into GIT and this fix will be included in the next AppImage release on March 31. I never could create the original problem and was confused by Pierre's report, but then I only perform simple editing in CinGG so would not have used a shortcut like Alt-right arrow. This must have been a very difficult bug to locate. Thank you, Georgy! |
|
|
This is now in the March 31 release and this BT will be closed in a couple of days. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-03-22 17:52 | sge | New Issue | |
| 2022-03-22 17:52 | sge | File Added: ContextManual-shuttle.diff.gz | |
| 2022-03-22 19:46 | PhyllisSmith | Assigned To | => PhyllisSmith |
| 2022-03-22 19:46 | PhyllisSmith | Status | new => acknowledged |
| 2022-03-22 19:46 | PhyllisSmith | Note Added: 0005250 | |
| 2022-03-23 15:57 | sge | Note Added: 0005252 | |
| 2022-03-23 20:13 | PhyllisSmith | Status | acknowledged => confirmed |
| 2022-03-23 20:13 | PhyllisSmith | Note Added: 0005254 | |
| 2022-03-31 22:57 | PhyllisSmith | Status | confirmed => resolved |
| 2022-03-31 22:57 | PhyllisSmith | Resolution | open => fixed |
| 2022-03-31 22:57 | PhyllisSmith | Note Added: 0005257 | |
| 2022-04-01 18:57 | PhyllisSmith | Status | resolved => closed |
